ENH: Use pathlib.full_match for pattern matching #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you, @kirkhansen! Could you check failing jobs, add a line in the changelog, and maybe a note on the readme to explain the behavior change & what users might have to update on their side? |
kirkhansen
force-pushed
the
issue-798
branch
3 times, most recently
from
1a699e1 to
ee261ee
Compare
Allows full directory matches and recursive patterns to succeed. Copies in some python 3.13 code for earlier python compatibility
TobiasRzepka
pushed a commit
to TobiasRzepka/watchdog
that referenced
this pull request
Oct 11, 2025
Allows full directory matches and recursive patterns to succeed. Copies in some python 3.13 code for earlier python compatibility Co-authored-by: Kirk Hansen <[email protected]>
TobiasRzepka
pushed a commit
to TobiasRzepka/watchdog
that referenced
this pull request
Oct 11, 2025
Allows full directory matches and recursive patterns to succeed. Copies in some python 3.13 code for earlier python compatibility Co-authored-by: Kirk Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation changes from
path.matchtopath.full_match, which will cause breaking changes in patterns specified by users; previous*.pythat would match python files will not actually work as the full path is now always matched; instead**/*.pyis needed. Tests updated to showcase that in practice.