Skip to content

Conversation

@zastrowm
Copy link
Contributor

@zastrowm zastrowm commented Sep 4, 2025

Add the manylinux_2_17 targets as requested by #1125

Targets being Added

The original issue suggested only adding manylinux_2_17_x86_64 and manylinux_2_17_aarch64; however, given that most of the popular packages targeted ppc64/armv7l/s390x/ppc64le/i686 and this package targeted those arch's for manylinux2014, I included them in this PR. If we wish to reduce it just to x64/aarch64, we can do that instead.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Sep 4, 2025

That's fine like this, thanks for the broader approach 💪

Wheels are properly created (https://github.com/gorakhargosh/watchdog/actions/runs/17475049194/job/49637638160?pr=1126):

(...)
-rw-r--r-- 1 runner docker 86529 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_aarch64.whl
-rw-r--r-- 1 runner docker 86531 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_armv7l.whl
-rw-r--r-- 1 runner docker 86527 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_i686.whl
-rw-r--r-- 1 runner docker 86530 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_ppc64.whl
-rw-r--r-- 1 runner docker 86530 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_ppc64le.whl
-rw-r--r-- 1 runner docker 86527 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_s390x.whl
-rw-r--r-- 1 runner docker 86528 Sep  4 20:58 watchdog-7.0.0-py3-none-manylinux_2_17_x86_64.whl
(...)

@BoboTiG BoboTiG merged commit 389bb16 into gorakhargosh:master Sep 4, 2025
17 of 24 checks passed
TobiasRzepka pushed a commit to TobiasRzepka/watchdog that referenced this pull request Oct 11, 2025
TobiasRzepka pushed a commit to TobiasRzepka/watchdog that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants