Add separate method for file/directory metadata modifcation #800

GreatBahram · 2021-05-29T08:26:14Z

Hi there,

As we discussed here #260, I tried to solve the problem using two new events for inotify, kqueue, and fsevents2 backends. So far, I've found no solution for the windows, as in this document describes it does not have an action for this purpose.

To be able to run it manually, currently it only works when you send a pull_request

.github/workflows/tests.yml

apparently, it is OK to have both on [pull_request, workflow_dispatch]

… and darwin kernels

…rks properly with FileAttrib and DirAttrib events

…ules

GreatBahram · 2021-06-24T09:08:39Z

Hi @BoboTiG,

Could you approve my workflows, please?

I changed the fsevents and fsevents2 modules, but I'm still unsure of them. The GitHub actions is very primitive; I could not get any guarantee out of it. But for inofity and kqueue, I tested them manually on Linux and Freebsd.

I’m eager to receive your feedback.

GreatBahram · 2021-06-24T16:38:30Z

The pipeline gives a bizarre error message. Do you know what the reason is?

OSError: [Errno 9] Bad file descriptor

BoboTiG · 2023-03-18T14:26:44Z

@GreatBahram I fixed conflicts, and rebased from master. Would you be able to double check I didn't alter what you've done in tests + fix linting/mypy issues 🙏🏻 ?

mmguero · 2023-04-06T20:26:35Z

Glad to see this PR is still alive, I'd love to see this get pulled.

tests/shell.py

src/watchdog/events.py

src/watchdog/observers/fsevents.py

BoboTiG · 2023-04-22T15:10:53Z

Several Mac, and Windows, tests are failing. I'l try to fix them later. I would like to have that PR merged for the upcoming version.

tests/test_fsevents.py

tests/test_emitter.py

tests/utils.py

tests/test_emitter.py

tests/utils.py

BoboTiG · 2023-04-24T07:49:24Z

A few remaining macOS tests to fix, and we will be good to merge.

BoboTiG · 2023-05-14T21:30:25Z

I finally have a Mac machine, it will be easier to fix those tests. I'll try to get it done "quickly".

tests/test_emitter.py

GreatBahram added 7 commits May 18, 2021 11:08

add fileattrib and dirattrib event

fc9b03a

use fileattrib and dirattrib event in inotify module

e693eb1

add on_attrib on LoggingEventHandler

2c66593

add changes to make kqueue support attrib event

937f9af

bring file/directory attribute change event into fsevents2 module

e2d8db0

update docs for FileAttrib and DirAttrib Events

3a652ff

Make flake8 happy

3b6f258

GreatBahram force-pushed the add-attributes-only branch from bbb72a0 to 3b6f258 Compare June 10, 2021 14:59

Change the test github workflow

151f651

To be able to run it manually, currently it only works when you send a pull_request

BoboTiG reviewed Jun 10, 2021

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

GreatBahram added 13 commits June 10, 2021 21:17

add on: pull_request workflow statement:

dc366d6

apparently, it is OK to have both on [pull_request, workflow_dispatch]

WIP: fix two more test cases and make sure they work correctly on bsd…

1ca76cb

… and darwin kernels

add test cases for file_attrib and dir_attrib

c3dc00f

add chmod function into shell module and add test cases to test it wo…

165a6f4

…rks properly with FileAttrib and DirAttrib events

I think I fixed the nested tese case

b710851

Make flake8 happier than ever

424cb47

WIP: Disable the lifecycle test case

58b514f

Update fsevents module: this should be tested more than any other mod…

677ac9f

…ules

bugfix test case: test_modify on BSD

467b1e2

return str repsentation instead of Pathlib object

5e94d19

make the equality method more strict

60415b7

run test work for pull_request and when user asks for it

9d0e19c

bugfix: document

dfb27d6

Update tests.yml

5921e2c

BoboTiG mentioned this pull request Jan 4, 2023

different/multiple types of modify events #893

Closed

BoboTiG added 3 commits March 18, 2023 15:09

Merge branch 'master' into add-attributes-only

2f8b573

Update tests.yml

167639f

Update kqueue.py

f751e7d

Apply suggestions from code review

dfa6db5

mmguero mentioned this pull request Apr 6, 2023

kubernetes deployment - inotify issue idaholab/Malcolm#168

Closed

BoboTiG added 2 commits April 22, 2023 15:38

Merge branch 'master' into add-attributes-only

4987d2b

Update test_emitter.py

008556d

BoboTiG reviewed Apr 22, 2023

View reviewed changes

tests/shell.py Outdated Show resolved Hide resolved

src/watchdog/events.py Show resolved Hide resolved

src/watchdog/events.py Show resolved Hide resolved

BoboTiG added 2 commits April 22, 2023 16:34

Apply suggestions from code review

408738f

Update test_emitter.py

7c8ac0b

BoboTiG reviewed Apr 22, 2023

View reviewed changes

src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved

src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved

src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved

BoboTiG added 2 commits April 22, 2023 17:01

Apply suggestions from code review

25adb67

Update test_emitter.py

4622197

BoboTiG added 4 commits April 22, 2023 17:13

Update test_fsevents.py

af9436e

Update test_emitter.py

8069705

Update conftest.py

6d03156

Update utils.py

79bec88

BoboTiG reviewed Apr 24, 2023

View reviewed changes

tests/test_fsevents.py Outdated Show resolved Hide resolved

Update tests/test_fsevents.py

f1593f4

BoboTiG reviewed Apr 24, 2023

View reviewed changes

tests/test_emitter.py Outdated Show resolved Hide resolved

Update tests/test_emitter.py

d2b3b24

BoboTiG reviewed Apr 24, 2023

View reviewed changes

tests/utils.py Show resolved Hide resolved

tests/test_emitter.py Outdated Show resolved Hide resolved

tests/utils.py Outdated Show resolved Hide resolved

Apply suggestions from code review

814d68e

sevenrats mentioned this pull request May 31, 2023

Make a distinction between content and metadata changes #260

Open

Merge branch 'master' into add-attributes-only

fe6c552

BoboTiG reviewed Jul 28, 2024

View reviewed changes

tests/test_emitter.py Outdated Show resolved Hide resolved

tests/test_emitter.py Outdated Show resolved Hide resolved

tests/test_emitter.py Outdated Show resolved Hide resolved

tests/test_emitter.py Outdated Show resolved Hide resolved

BoboTiG added 2 commits July 28, 2024 15:32

Apply suggestions from code review

550ec1d

Merge branch 'master' into add-attributes-only

6c8b6c7

Uh oh!

Add separate method for file/directory metadata modifcation #800

Are you sure you want to change the base?

Add separate method for file/directory metadata modifcation #800

Uh oh!

Conversation

GreatBahram commented May 29, 2021

Uh oh!

Uh oh!

GreatBahram commented Jun 24, 2021

Uh oh!

GreatBahram commented Jun 24, 2021

Uh oh!

BoboTiG commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmguero commented Apr 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BoboTiG commented Apr 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BoboTiG commented Apr 24, 2023

Uh oh!

BoboTiG commented May 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BoboTiG commented Mar 18, 2023 •

edited

Loading