User data as store flow path#28
Merged
Merged
Conversation
pg is not part of erlang-red modules.
There are some enviroments whe erlang-red is running as a non-privileged user. Thus, if erlang-red is installed on /usr/ path it will not have the correct permissions when writing flows to disk. This change allows erlang-red compute a store flow path based on: 1. if flow_store application property has been configured, erlang-red will use that value. Otherwise: 2. get `user_data` [1] from filename:basedir/2 as a base folder for storing flows. e.g.: in my host (linux based) the store folder is /home/joaohf/.local/share/erlang-red/ 1: https://www.erlang.org/doc/apps/stdlib/filename.html#basedir/3
Contributor
Author
|
Hi @gorenje let me know what you think. I tried to describe my use case and a patch to accommodate that situation. |
Owner
|
Hi @joaohf Looks good to me - I'll test locally and then merge here. Not sure about why the tests are failing hence I want to have a look on my local machine first. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute store flow path based on user_data folder