fix: allow initial snapPoint index greater than 0#1694
Open
BethThomas141 wants to merge 1 commit intogorhom:v4from
Open
fix: allow initial snapPoint index greater than 0#1694BethThomas141 wants to merge 1 commit intogorhom:v4from
BethThomas141 wants to merge 1 commit intogorhom:v4from
Conversation
|
Any plans on merging this fix? I had to apply a patch with this fix since I was experiencing the same error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is to fix bug #1689.
Since version 4.5.0 there has been logic that if the container layout is not ready, the returned snapPoints are an array with just a single item
[-999]. As a result, on initial load, before the container layout is ready, if you have passed in the index prop to theBottomSheetwith a value greater than 0 (e.g. if you're passing in more than one snap point value, and have passed inindex={1}as you want the drawer to start open), it immediately errors as the index is out of range of the initial snapPoint array of[-999].This PR reverts the initial load logic to how it was before version 4.5.0, where if the container layout is not yet ready, it returns instead an array filled with
-999that matches the length of the passed in snapPoint array.