fix: prevent canceling touchmove events when not cancelable #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warnings about attempting to cancel touchmove events with cancelable=false by checking the event.cancelable property before calling preventDefault()
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
not state |
|
thanks @erickreutz for submitting this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes warnings about attempting to cancel touchmove events with cancelable=false by adding checks for the event.cancelable property before calling preventDefault().
Details
The error 'Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted' occurs when the code tries to call preventDefault() on a touchmove event that has cancelable=false (which happens during active scrolling).
The fix adds event.cancelable checks in all three places where preventDefault() is called in the useScrollHandler.web.ts file.