feat: Add position params in onAnimate event #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
force-pushed
the
souyahia/on-animate-position-params
branch
from
f94bb72 to
54f52e1
Compare
|
thanks @souyahia for this PR, it should be release shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Add
fromPositionandtoPositionparams to theonAnimateevent.Motivation
There are certain cases where this could be useful (we already have the position info in the
onChangecallback). For example, when the sheets is animating to a position that is not part of the specified snap points, thetoIndexwill be-1(which is expected since the snap point does not exist) even though the sheet will be closed. See this issue for instance.