-
-
Notifications
You must be signed in to change notification settings - Fork 932
Add react-native-reanimated v4 support #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucaswitch
wants to merge
8
commits into
gorhom:master
Choose a base branch
from
lucaswitch:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
18448fb
feat: add support to react-native-reanimated v4
lucaswitch fb0bb77
feat: add support to react-native-reanimated v4
lucaswitch 2ec7d56
fix: fix backwards support to v3
lucaswitch 9855aea
fix: fix useWorkletCallback definition
lucaswitch 9c908b9
fix: add upgrade reanimated notice and add worklet functions annotations
lucaswitch a6dfe2c
fix: add the useCallback approach
lucaswitch f933756
fix: fix example and update example deps and babel configs to support…
lucaswitch e007f43
fix: revert bottom sheet default index on reanimated v4
lucaswitch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { useCallback} from 'react'; | ||
| import * as Reanimated from 'react-native-reanimated'; | ||
|
|
||
|
|
||
| // @ts-ignore Runtime check if has useWorkletCallback for supporting reanimated v3 and v4 at the same time. | ||
| const hasCallbackWorklet = typeof Reanimated?.useWorkletCallback === 'function'; | ||
|
|
||
| /** | ||
| * Provide the same functionality that we had in reanimated v3. | ||
| * @param callback | ||
| */ | ||
| export const useWorkletCallback = hasCallbackWorklet | ||
| ? (Reanimated.useWorkletCallback as <T extends (...args: any[]) => any>(cb: T, deps: readonly unknown[]) => T) | ||
| : function useWorkletCallback<T extends (...args: any[]) => any>(callback: T, deps: readonly unknown[]): T { | ||
| return useCallback((...args: Parameters<T>): ReturnType<T> => { | ||
| 'worklet'; | ||
| return callback?.(...args); | ||
| }, deps) as T; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error:
Error: [Worklets] Tried to synchronously call a non-worklet functionevaluatePositionon the UI thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i'm seeing that error still looks like the current approach is not enough for inner functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluatePositionis broken: