-
Notifications
You must be signed in to change notification settings - Fork 27
fix wrapper command #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix wrapper command #402
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list. |
|
Hey! Thanks for your PR. Sorry for the late response. The test backend doesn't need API keys anymore, so you can just hook that up. I will try to take a look at this PR this weekend! |
|
Oh I see, I’ll test this once I get home then an update you/modify my commit. You should also probably update the readme 😅, thanks! |
|
Hey, @blarfoon, sorry if this is a bother, but I have been unable to test these changes myself as prism cannot be installed on my system for some reason, probably because I am on linux. I have signed the CLA here gorilla-devs/clabot-config#12, and am waiting for it to be merged. if you could take a look at this, that would be great, I will try a little more to get a development environment up and update you if I succeed. Thanks for all of your work on this project! |
|
|
|
|
|
Good catch on the issue. I think the proposed solution is too brittle. I would suggest implementing a proper parsing using shlex which is already used elsewhere as well. Let me know if I can be of any help or if you want me to do it instead. Davide |
This PR allegedly fixes the issue described in #401 I say allegedly, because, well, I cant actually test it, because I need an API key, and I like to ship fast since it should be a simple fix, here it is. Let me restate that the fix is UNTESTED and tbf I dont even know if it works properly. if it doesnt and you want me to get back to work, you can issue me an api key at [email protected] or dont 🤷♀️