Skip to content

Conversation

@juls0730
Copy link

This PR allegedly fixes the issue described in #401 I say allegedly, because, well, I cant actually test it, because I need an API key, and I like to ship fast since it should be a simple fix, here it is. Let me restate that the fix is UNTESTED and tbf I dont even know if it works properly. if it doesnt and you want me to get back to work, you can issue me an api key at [email protected] or dont 🤷‍♀️

@cla-bot
Copy link

cla-bot bot commented Jan 31, 2025

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please send a signing request to [email protected] and add your github handle to contributors list.

@blarfoon
Copy link
Member

Hey! Thanks for your PR.

Sorry for the late response. The test backend doesn't need API keys anymore, so you can just hook that up.

I will try to take a look at this PR this weekend!

@juls0730
Copy link
Author

Oh I see, I’ll test this once I get home then an update you/modify my commit. You should also probably update the readme 😅, thanks!

@juls0730
Copy link
Author

juls0730 commented Feb 21, 2025

Hey, @blarfoon, sorry if this is a bother, but I have been unable to test these changes myself as prism cannot be installed on my system for some reason, probably because I am on linux. I have signed the CLA here gorilla-devs/clabot-config#12, and am waiting for it to be merged. if you could take a look at this, that would be great, I will try a little more to get a development environment up and update you if I succeed.

Thanks for all of your work on this project!
Zoe

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ blarfoon
❌ juls0730
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@blarfoon
Copy link
Member

blarfoon commented Oct 3, 2025

Good catch on the issue. I think the proposed solution is too brittle. I would suggest implementing a proper parsing using shlex which is already used elsewhere as well.

Let me know if I can be of any help or if you want me to do it instead.

Davide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants