fix: merge methods when Route.Methods is called repeatedly#802
Open
leno23 wants to merge 1 commit into
Open
Conversation
Chaining Methods() on the same route previously added independent matchers, requiring every method to match the same request and causing 405 responses for valid verbs like PUT and PATCH. Merge repeated calls into a single method matcher and aggregate methods in GetMethods(). Fixes gorilla#694
leno23
force-pushed
the
fix/route-methods-merge-694
branch
from
69b535b to
50a3f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calling
Route.Methods()more than once on the same route previously added independent method matchers. A request had to satisfy every matcher, which is impossible for a single HTTP method and surfaced as405 Method Not Allowed(e.g..Methods("PUT").Methods("PATCH")).Repeated calls now merge into one matcher.
GetMethods()aggregates methods from all method matchers on the route.Fixes #694
Test plan
go test ./...TestRouteMethodsRepeatedCallsTestSubrouterMatching/methodexpectations for merged semantics