Skip to content

Update decoder to not panic when there are unexported fields in a different package. #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update decoder to not panic when there are unexported fields in a different package. #236

wants to merge 1 commit into from

Conversation

rishavm47
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Fix a bug to make this backward compatible with v1.2.1

Related Tickets & Documents

#234

Added/updated tests?

  • Yes
  • No, and this is why: small change
  • I need help with writing tests

Run verifications and test

  • make verify is passing (failing the same like it fails for main branch)
  • make test is passing

@rishavm47
Update decoder.go
b333518 
Signed-off-by: Rishav Maheshwari <[email protected]>
@rishavm47
Copy link
Author

@zak905 Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Do not encode unexported fields
1 participant
@rishavm47