Return error from Registry.Get when store.New returns a nil session#292
Closed
c-tonneslan wants to merge 1 commit into
Closed
Return error from Registry.Get when store.New returns a nil session#292c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
If a Store's New method returns (nil, err), Registry.Get used to dereference session.name on the nil pointer and panic. Return the error directly when New gives back no session. Fixes gorilla#288 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
Author
|
Closing in favor of #291 which I already had open for the same issue. Sorry for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288.
Registry.Getassumedstore.Newalways returned a non-nil session, but aStoreis free to return(nil, err). The next line touchedsession.nameand panicked with a nil pointer dereference.Just return the error directly when the store gives back no session. Added a regression test that exercises the failing-store path.
Fixes #288