Skip to content

Use struct{} instead of bool as value type #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use struct{} instead of bool as value type #981

wants to merge 1 commit into from

Conversation

mutn3ja
Copy link

@mutn3ja mutn3ja commented Mar 19, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

map[T]struct{} is idiomatic way to use sets in go

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes
  • No, and this is why: this change doesn't change functionality
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

Use struct{} instead of bool as value type
25185fb 
map[T]struct{} is idiomatic way to use sets in go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mutn3ja