Fix bytes.Reader issues #1055
Open
ckbaker10 wants to merge 3 commits intogoss-org:masterfrom
Open
Conversation
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
fileresourcecontentschecks always reportedobject: *bytes.Readeron failure instead of the actual file content, making it completely useless for debugging.Root cause: in
ValidateGomegaValue, thefunc() (io.Reader, error)switch arm calledf()and passed the rawio.ReaderasfoundValuetoHavePatterns. The matcher scanned it fine, but once consumed,FailureResulthad nothing left to read and fell through tofmt.Sprintf("object: %T", actual).Fix: materialize the reader into a string immediately in the switch arm before handing it to the matcher.
HavePatternsalready handles string input, andFailureResultalready formats strings correctly — so no changes needed there.Updated three golden test fixtures that were asserting the broken
"object: *strings.Reader"output.