CMake: link gost.so statically to its caller #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any executable loads `gost.so`, the executable already either has `libcrypto.so` loaded or is statically linked against `libcrypto.a`. Anyway it already has all libcrypto (and libssl) symbols present. Without this patch `gost.so` is linked against `libcrypto.so`. As a result, a diamond dependency is introduced. If `gost.so` is then loaded by an executable which is statically linked against libcrypto, `ld` will insist on loading `libcripto.so`, despite the executable already having all necessary symbols. When the executable is statically linked, shared objects for libcrypto and libssl are usually not built, `ld` won't find them, and the caller will crush. The patch removes this unnecessary link dependency in `gost.so`, allowing it to be used by executables which are statically linked against libcrypto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any executable loads
gost.so, the executable already either haslibcrypto.soloaded or is statically linked againstlibcrypto.a.Anyway it already has all libcrypto (and libssl) symbols present.
Without this patch
gost.sois linked againstlibcrypto.so. Asa result, a diamond dependency is introduced. If
gost.sois thenloaded by an executable which is statically linked against libcrypto,
ldwill insist on loadinglibcripto.so, despite the executablealready having all necessary symbols. When the executable is statically
linked, shared objects for libcrypto and libssl are usually not built,
ldwon't find them, and the caller will crush.The patch removes this unnecessary link dependency in
gost.so,allowing it to be used by executables which are statically linked
against libcrypto.