removed em-dashes from most of the comments and texts#1130
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (114)
🚧 Files skipped from review as they are similar to previous changes (94)
📝 WalkthroughWalkthroughThis PR standardizes comment and documentation punctuation, wording, and line wrapping across the Rust workspace. It does not change executable logic, control flow, public APIs, test assertions, or runtime behavior. ChangesDocumentation normalization
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/gosub_html5/src/tokenizer/replacement_tables.rs`:
- Line 57: Update the comment labeling the U+2014 mapping in the replacement
table to accurately identify it as an em dash, using “EM DASH (U+2014)” or “EM
DASH” instead of the hyphen-minus notation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 22a9959e-0781-4563-91a5-40796890097b
📒 Files selected for processing (115)
bin/gosub-screenshot/main.rscrates/gosub_config/src/lib.rscrates/gosub_css3/examples/css_corpus_match.rscrates/gosub_css3/src/colors.rscrates/gosub_css3/src/functions/math.rscrates/gosub_css3/src/functions/var.rscrates/gosub_css3/src/matcher/property_definitions.rscrates/gosub_css3/src/matcher/shorthands.rscrates/gosub_css3/src/matcher/styling.rscrates/gosub_css3/src/matcher/syntax.rscrates/gosub_css3/src/matcher/syntax_matcher.rscrates/gosub_css3/src/parser/declaration.rscrates/gosub_css3/src/stylesheet.rscrates/gosub_css3/src/system.rscrates/gosub_css3/tools/generate_definitions/src/types.rscrates/gosub_engine/src/engine/context.rscrates/gosub_engine/src/engine/cookies.rscrates/gosub_engine/src/engine/cookies/cookie_jar.rscrates/gosub_engine/src/engine/cookies/cookies.rscrates/gosub_engine/src/engine/cookies/store.rscrates/gosub_engine/src/engine/cookies/tests.rscrates/gosub_engine/src/engine/engine.rscrates/gosub_engine/src/engine/settings_store.rscrates/gosub_engine/src/engine/storage.rscrates/gosub_engine/src/engine/tab/options.rscrates/gosub_engine/src/engine/tab/scroll.rscrates/gosub_engine/src/engine/tab/worker.rscrates/gosub_engine/src/engine/zone.rscrates/gosub_engine/src/html.rscrates/gosub_engine/src/lib.rscrates/gosub_engine/src/net/decision/sniff.rscrates/gosub_fontmanager/src/cosmic_system.rscrates/gosub_fontmanager/src/pango_system.rscrates/gosub_fontmanager/src/parley_system.rscrates/gosub_fontmanager/src/skia_system.rscrates/gosub_html5/src/document/document_impl.rscrates/gosub_html5/src/parser/helper.rscrates/gosub_html5/src/testing/tree_construction/generator.rscrates/gosub_html5/src/tokenizer/replacement_tables.rscrates/gosub_interface/src/config.rscrates/gosub_interface/src/css3.rscrates/gosub_interface/src/document.rscrates/gosub_interface/src/font_system.rscrates/gosub_interface/src/render/backend.rscrates/gosub_interface/src/render/render_list.rscrates/gosub_lattice/src/bin/table_console.rscrates/gosub_lattice/src/compute.rscrates/gosub_lattice/src/grid.rscrates/gosub_lattice/src/lib.rscrates/gosub_lattice/src/mock.rscrates/gosub_lattice/src/model.rscrates/gosub_lattice/src/sizing/columns.rscrates/gosub_lattice/src/sizing/rows.rscrates/gosub_lattice/src/tests.rscrates/gosub_lattice/src/types.rscrates/gosub_render_pipeline/examples/pipeline_bench.rscrates/gosub_render_pipeline/examples/screenshot.rscrates/gosub_render_pipeline/src/common/document/inline_style.rscrates/gosub_render_pipeline/src/common/document/node.rscrates/gosub_render_pipeline/src/common/document/pipeline_doc.rscrates/gosub_render_pipeline/src/common/document/style.rscrates/gosub_render_pipeline/src/common/font/parley.rscrates/gosub_render_pipeline/src/common/media/decoder.rscrates/gosub_render_pipeline/src/common/media/decoder/svg.rscrates/gosub_render_pipeline/src/common/media/media_store.rscrates/gosub_render_pipeline/src/common/media/svg.rscrates/gosub_render_pipeline/src/layering/layer.rscrates/gosub_render_pipeline/src/layouter.rscrates/gosub_render_pipeline/src/layouter/css_taffy_converter.rscrates/gosub_render_pipeline/src/layouter/inline_run.rscrates/gosub_render_pipeline/src/layouter/table.rscrates/gosub_render_pipeline/src/layouter/taffy.rscrates/gosub_render_pipeline/src/painter.rscrates/gosub_render_pipeline/src/painter/commands.rscrates/gosub_render_pipeline/src/painter/commands/text.rscrates/gosub_render_pipeline/src/rasterizer.rscrates/gosub_render_pipeline/src/render/tile_composite.rscrates/gosub_render_pipeline/src/rendertree_builder/tree.rscrates/gosub_render_pipeline/src/tiler.rscrates/gosub_renderer_cairo/src/backend.rscrates/gosub_renderer_cairo/src/lib.rscrates/gosub_renderer_cairo/src/rasterizer.rscrates/gosub_renderer_cairo/src/rasterizer/svg.rscrates/gosub_renderer_cairo/src/rasterizer/text/glyphs.rscrates/gosub_renderer_dynamic/src/lib.rscrates/gosub_renderer_skia/src/backend.rscrates/gosub_renderer_skia/src/rasterizer.rscrates/gosub_renderer_skia/src/rasterizer/svg.rscrates/gosub_renderer_skia/src/rasterizer/text/glyphs.rscrates/gosub_renderer_vello/src/backend.rscrates/gosub_renderer_vello/src/backend/text_renderer.rscrates/gosub_renderer_vello/src/gpu_tiles.rscrates/gosub_renderer_vello/src/rasterizer.rscrates/gosub_renderer_vello/src/rasterizer/brush.rscrates/gosub_renderer_vello/src/rasterizer/svg.rscrates/gosub_renderer_vello/src/rasterizer/text/glyphs.rscrates/gosub_shared/src/animation.rscrates/gosub_shared/src/async_executor.rscrates/gosub_shared/src/byte_stream.rscrates/gosub_shared/src/timing.rscrates/gosub_web_platform/src/lib.rscrates/gosub_winit/src/lib.rsexamples/egui-cairo/main.rsexamples/egui-skia/main.rsexamples/egui-vello/main.rsexamples/gtk4-cairo/main.rsexamples/gtk4-skia/main.rsexamples/hello-world.rsexamples/metrics_cli.rsexamples/pipeline-test.rsexamples/tutorial.rsexamples/winit-cairo/main.rsexamples/winit-skia-gpu/main.rsexamples/winit-skia/main.rsexamples/winit-vello/main.rs
| // EN DASH (–) | ||
| 0x96_u32 => '\u{2013}', | ||
| // EM DASH (—) | ||
| // EM DASH (-) |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the character name accurate.
The mapped value is U+2014, but - denotes a hyphen-minus (U+002D), not an em dash. Use // EM DASH (U+2014) or simply // EM DASH instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/gosub_html5/src/tokenizer/replacement_tables.rs` at line 57, Update
the comment labeling the U+2014 mapping in the replacement table to accurately
identify it as an em dash, using “EM DASH (U+2014)” or “EM DASH” instead of the
hyphen-minus notation.
Ok, so this is currently the sad state of AI usage in projects. We/I feel that AI is a very robust tool to help us with defining problems, laying out solutions, and implement them. All under our guidance and inspection. It works faster and results often in better code than I could personally write myself. Not because I have no clue what i'm doing (i hope i have by now), but mostly because I literally didn't think of solving some problems in a way that an LLM came up with. And sometimes, it finds ways that are too ridiculous and with some rewrites we got it back working. Most of the time, I feel like it uses the same solution i would do myself, only it's 10 times faster in producing it. Anyhow, there are many different ways on how to use AI, and I think is very dangerous that the current mindset by too many people is that when you use AI, it must be slop. It just screams insecurity in my opinion. So the first thing that people will check on ANY repo: is there even a miniscule trace of AI that I can detect in this repo? If so, i will not be looking any further and will scream AI-slop at the nearest forum i can find. This is why i'm removing the em-dashes, the number one telltale on AI generated content/comments. Not because I don't approve the comments itself (i think most of them are fine, but it's a big project, and there are bound to be some spillage here and there that we should change/update), but I don't approve of the way people will NOT read the comments, but rather fall over the em-dash being present. Without them, it might make people actually read the comments, the code, and decide for themselves if something is AI slop or not. I don't like that this is the way we have to work at this point in time, but it is the way it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so this is currently the sad state of AI usage in projects. We/I feel that AI is a very robust tool to help us with defining problems, laying out solutions, and implement them. All under our guidance and inspection.
It works faster and results often in better code than I could personally write myself. Not because I have no clue what i'm doing (i hope i have by now), but mostly because I literally didn't think of solving some problems in a way that an LLM came up with. And sometimes, it finds ways that are too ridiculous and with some rewrites we got it back working. Most of the time, I feel like it uses the same solution i would do myself, only it's 10 times faster in producing it.
Anyhow, there are many different ways on how to use AI, and I think is very dangerous that the current mindset by too many people is that when you use AI, it must be slop. It just screams insecurity in my opinion.
So the first thing that people will check on ANY repo: is there even a miniscule trace of AI that I can detect in this repo? If so, i will not be looking any further and will scream AI-slop at the nearest forum i can find.
This is why i'm removing the em-dashes, the number one telltale on AI generated content/comments. Not because I don't approve the comments itself (i think most of them are fine, but it's a big project, and there are bound to be some spillage here and there that we should change/update), but I don't approve of the way people will NOT read the comments, but rather fall over the em-dash being present.
Without them, it might make people actually read the comments, the code, and decide for themselves if something is AI slop or not.
I don't like that this is the way we have to work at this point in time, but it is the way it is.
Summary by CodeRabbit