Remove unused Go version checks and related test data - #563
Merged
dnephin merged 1 commit intoApr 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy Go-version conditional logic and redundant golden test outputs now that the project targets Go 1.24+.
Changes:
- Remove Go version gating/selection logic in
cmd/main_e2e_test.goand uset.Name()directly for golden paths. - Delete Go-version-specific golden files (
*-go1.23) forTestE2E_RerunFails. - Remove unused build-tagged helpers for Go version checks (
cmd/goversion_*.go).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_until_success-go1.23 | Removes unused Go 1.23-specific expected output. |
| cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_continues_to_fail-go1.23 | Removes unused Go 1.23-specific expected output. |
| cmd/testdata/e2e/expected/TestE2E_RerunFails/first_run_has_errors,_abort_rerun-go1.23 | Removes unused Go 1.23-specific expected output. |
| cmd/main_e2e_test.go | Drops Go version branching/skip logic and simplifies golden file selection. |
| cmd/goversion_old.go | Removes unused pre-go1.22 build-tagged version stub. |
| cmd/goversion_go122.go | Removes unused go1.22 build-tagged version comparator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All these files are unused since the tool supports Go 1.24+.