Skip to content

Remove unused Go version checks and related test data - #563

Merged
dnephin merged 1 commit into
gotestyourself:mainfrom
alexandear-org:refactor/remove-unused-go-version
Apr 15, 2026
Merged

Remove unused Go version checks and related test data#563
dnephin merged 1 commit into
gotestyourself:mainfrom
alexandear-org:refactor/remove-unused-go-version

Conversation

@alexandear

Copy link
Copy Markdown
Contributor

All these files are unused since the tool supports Go 1.24+.

Copilot AI review requested due to automatic review settings April 10, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy Go-version conditional logic and redundant golden test outputs now that the project targets Go 1.24+.

Changes:

  • Remove Go version gating/selection logic in cmd/main_e2e_test.go and use t.Name() directly for golden paths.
  • Delete Go-version-specific golden files (*-go1.23) for TestE2E_RerunFails.
  • Remove unused build-tagged helpers for Go version checks (cmd/goversion_*.go).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_until_success-go1.23 Removes unused Go 1.23-specific expected output.
cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_continues_to_fail-go1.23 Removes unused Go 1.23-specific expected output.
cmd/testdata/e2e/expected/TestE2E_RerunFails/first_run_has_errors,_abort_rerun-go1.23 Removes unused Go 1.23-specific expected output.
cmd/main_e2e_test.go Drops Go version branching/skip logic and simplifies golden file selection.
cmd/goversion_old.go Removes unused pre-go1.22 build-tagged version stub.
cmd/goversion_go122.go Removes unused go1.22 build-tagged version comparator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dnephin dnephin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dnephin
dnephin merged commit 3cf1435 into gotestyourself:main Apr 15, 2026
11 of 12 checks passed
@alexandear
alexandear deleted the refactor/remove-unused-go-version branch April 15, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants