Workflow action version updates #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Dec 1, 2024
.github/workflows/main.yml
Outdated
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'zulu' |
There was a problem hiding this comment.
We are using the same one as before:
https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md
You can change it if you want:
https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions
There was a problem hiding this comment.
Ahh okay, do you have a preference? I think temurin is more open, as it's maintained eclipse?
There was a problem hiding this comment.
Based on https://whichjdk.com/, temurin sounds good
There was a problem hiding this comment.
I mostly use Zulu or SapMachine, but only because they just work. I never bothered to change it for my projects.
There was a problem hiding this comment.
Okay, then let's go with temurin, if the build succeeds (:.
jmattheis
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the actions to much newer versions