fix: less whitespace in message & add app name #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
commented
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 56 56
Lines 2645 2645
=======================================
Hits 2104 2104
Misses 450 450
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks great to me, I personally prefer a more compact and information dense look like this. (I haven't tried it live yet) |
jmattheis
force-pushed
the
message-style
branch
from
374b6e0 to
4ce8ce5
Compare
jmattheis
commented
Aug 9, 2025
ui/src/message/Message.tsx
Outdated
| @@ -1,4 +1,4 @@ | |||
| import {Button, Theme, useMediaQuery, useTheme} from '@mui/material'; | |||
| import {Box, Button, Theme, useMediaQuery, useTheme} from '@mui/material'; | |||
There was a problem hiding this comment.
I've updated the description with new screenshots. The mobile style now has a different header layout. @eternal-flame-AD do you have a better idea for the application image in the mobile layout, it looks a little out of place but at least it's more compact?
jmattheis
force-pushed
the
message-style
branch
2 times, most recently
from
1404e8f to
ff086d5
Compare
jmattheis
force-pushed
the
message-style
branch
from
ff086d5 to
94f5df5
Compare
jmattheis
force-pushed
the
message-style
branch
from
94f5df5 to
cd2b416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion from #819 (comment)
@eternal-flame-AD what do you think?
desktop:
mobile: