Adds Redis pub/sub for multi-pod WebSocket support #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a message broker system with Redis backend to enable WebSocket notifications across multiple Gotify server instances. Introduces a broker interface with Redis and no-op implementations, allowing deployments to scale horizontally while maintaining real-time message delivery. Falls back gracefully to local-only mode when Redis is disabled or unavailable. Includes configuration options for Redis connection and channel prefix customization.
|
Hi, is this a performance PR or some specific infrastructure that requires this horizontal/message bus setup? If it's performance it would be nice if you have benchmark or load testing numbers (concurrent connections, etc). If it's a specific infrastructure (maybe k8s?) you are targeting please open an concurrent issue/PR at gotify/website for how to configure the system to take advantage of this feature. (Example configurations, security considerations, etc) |
|
It is targeting an infrastructure like k8s. |
|
Okay thanks for the clarification, can you open PR for a sample k8s configuration with this feature on gotify/website, thanks. |
|
Thank you, I will open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a message broker system with Redis backend to enable WebSocket notifications across multiple Gotify server instances. Introduces a broker interface with Redis and no-op implementations, allowing deployments to scale horizontally while maintaining real-time message delivery.
Falls back gracefully to local-only mode when Redis is disabled or unavailable. Includes configuration options for Redis connection and channel prefix customization.