-
-
Notifications
You must be signed in to change notification settings - Fork 766
feat: refine AutoCert logic #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: eternal-flame-AD <[email protected]>
Signed-off-by: eternal-flame-AD <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 79.54% 78.77% -0.78%
==========================================
Files 56 56
Lines 2645 2671 +26
==========================================
Hits 2104 2104
- Misses 450 476 +26
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: eternal-flame-AD <[email protected]>
|
57d12dd
to
304569b
Compare
Signed-off-by: eternal-flame-AD <[email protected]>
304569b
to
e4a7205
Compare
Should these changes be released right now? |
I am not sure is this a regression (doesn't seem like it, but that could be just because this renewal code path is so cold regression don't show up quickly)? If so then probably. Otherwise up to you I am neutral I currently don't have a machine/IP I can test this process end to end, so far my testing only goes the challenge process works and errors work and ALPN happened not that it solved any particular issues, if you have one can you test it? |
It seems like the Autocert logic can be quite confusing and errors can be implicit ..
This tries to: