Skip to content

Conversation

xavier-GitHub76
Copy link
Contributor

I add a delete button (appearing when the mouse hovers over image)
After confirmation, the delete is done (the API 'DELETE /:id/image' is used) and a snack notification is created

@xavier-GitHub76 xavier-GitHub76 requested a review from a team as a code owner October 6, 2025 19:57
@xavier-GitHub76
Copy link
Contributor Author

Delete.image.webm

image,
fEdit,
}: IRowProps) => {
const [isHovered, setIsHovered] = useState(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this to handle the hover effect purely with css and the image always has the onclick handler to delete the image. This make this simpler IMO.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.76%. Comparing base (4bc42d2) to head (09e495b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          56       56           
  Lines        2670     2670           
=======================================
  Hits         2103     2103           
  Misses        476      476           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmattheis jmattheis merged commit 9703021 into gotify:master Oct 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants