Skip to content

fix: fix markdown embed image issue #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2025
Merged

fix: fix markdown embed image issue #857

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
167f442
fix: fix markdown embed image issue
ggqshr Oct 11, 2025
9825769
fix urlTransform filter condition
ggqshr Oct 11, 2025
82ab0e9
fix code format
ggqshr Oct 11, 2025
193e5c6
add image/gif filter
ggqshr Oct 13, 2025
5244fa1
Format code
eternal-flame-AD Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ui/src/common/Markdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
import React from 'react';
import ReactMarkdown from 'react-markdown';
import ReactMarkdown, {defaultUrlTransform} from 'react-markdown';
import type {UrlTransform} from 'react-markdown';
import gfm from 'remark-gfm';

// Copy from mlflow/server/js/src/shared/web-shared/genai-markdown-renderer/GenAIMarkdownRenderer.tsx
// Related PR: https://github.com/mlflow/mlflow/pull/16761
const urlTransform: UrlTransform = (value) => {
if (value.startsWith('data:image/png;') || value.startsWith('data:image/jpeg;')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the gotify/android we support a few more formats, maybe we could add image/gif here too? This seems like a commonly used format. For the rest we can wait until someone reports an issue.

return value;
}
return defaultUrlTransform(value);
};

export const Markdown = ({
children,
onImageLoaded = () => {},
Expand All @@ -11,7 +21,8 @@ export const Markdown = ({
}) => (
<ReactMarkdown
components={{img: ({...props}) => <img onLoad={onImageLoaded} {...props} />}}
remarkPlugins={[gfm]}>
remarkPlugins={[gfm]}
urlTransform={urlTransform}>
{children}
</ReactMarkdown>
);
Loading