Skip to content

feat: add kafka sink in firehose #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumitaich1998 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add kafka sink in firehose #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eddb392
[phase-2] Add KAFKA to SinkType enum
sumitaich1998 May 13, 2026
9bccc44
[phase-2] Wire KafkaSinkFactory into Firehose SinkFactory
sumitaich1998 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/gotocompany/firehose/config/enums/SinkType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ public enum SinkType {
BIGQUERY,
BIGTABLE,
MONGODB,
MAXCOMPUTE
MAXCOMPUTE,
KAFKA
}
10 changes: 10 additions & 0 deletions src/main/java/com/gotocompany/firehose/sink/SinkFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
import com.gotocompany.depot.config.BigQuerySinkConfig;
import com.gotocompany.depot.config.BigTableSinkConfig;
import com.gotocompany.depot.config.HttpSinkConfig;
import com.gotocompany.depot.config.KafkaSinkConfig;
import com.gotocompany.depot.config.RedisSinkConfig;
import com.gotocompany.depot.http.HttpSink;
import com.gotocompany.depot.kafka.KafkaSink;
import com.gotocompany.depot.kafka.KafkaSinkFactory;
import com.gotocompany.depot.log.LogSink;
import com.gotocompany.depot.log.LogSinkFactory;
import com.gotocompany.depot.maxcompute.MaxComputeSink;
Expand Down Expand Up @@ -49,6 +52,7 @@ public class SinkFactory {
private RedisSinkFactory redisSinkFactory;
private com.gotocompany.depot.http.HttpSinkFactory httpv2SinkFactory;
private MaxComputeSinkFactory maxComputeSinkFactory;
private com.gotocompany.depot.kafka.KafkaSinkFactory kafkaSinkFactory;

public SinkFactory(KafkaConsumerConfig kafkaConsumerConfig,
StatsDReporter statsDReporter,
Expand Down Expand Up @@ -111,6 +115,10 @@ public void init() {
maxComputeSinkFactory = new MaxComputeSinkFactory(statsDReporter, stencilClient, config);
maxComputeSinkFactory.init();
return;
case KAFKA:
kafkaSinkFactory = new com.gotocompany.depot.kafka.KafkaSinkFactory(config, statsDReporter);
kafkaSinkFactory.init();
return;
default:
throw new ConfigurationException("Invalid Firehose SINK_TYPE");
}
Expand Down Expand Up @@ -148,6 +156,8 @@ public Sink getSink() {
return new GenericSink(new FirehoseInstrumentation(statsDReporter, HttpSink.class), sinkType.name(), httpv2SinkFactory.create());
case MAXCOMPUTE:
return new GenericSink(new FirehoseInstrumentation(statsDReporter, MaxComputeSink.class), sinkType.name(), maxComputeSinkFactory.create());
case KAFKA:
return new GenericSink(new FirehoseInstrumentation(statsDReporter, KafkaSink.class), sinkType.name(), kafkaSinkFactory.create());
default:
throw new ConfigurationException("Invalid Firehose SINK_TYPE");
}
Expand Down
Loading