feat: add support for approval_id in update_approval api#230
Open
anjali9791 wants to merge 1 commit into
Open
Conversation
anjali9791
force-pushed
the
feat/update_approval
branch
2 times, most recently
from
1428f5c to
3bc3d4a
Compare
anjali9791
force-pushed
the
feat/update_approval
branch
from
3bc3d4a to
c4136e0
Compare
bearaujus
reviewed
Oct 13, 2025
bearaujus
reviewed
Oct 13, 2025
| currentApproval := appeal.GetApproval(approvalAction.ApprovalName) | ||
| // Prioritize approval_id over approval_name | ||
| var currentApproval *domain.Approval | ||
| if approvalAction.ApprovalID != "" { |
There was a problem hiding this comment.
(Optional) This able to eliminate the else branch
Suggested change
| if approvalAction.ApprovalID != "" { | |
| sel := approvalAction.ApprovalName | |
| if approvalAction.ApprovalID != "" { | |
| sel = approvalAction.ApprovalID | |
| } | |
| currentApproval = appeal.GetApproval(sel) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.