feat: add grant drift check job & notify result to PD#298
Open
ahmadnaufal wants to merge 9 commits into
Open
Conversation
ahmadnaufal
force-pushed
the
feat/grant-drift-check-notify-pd
branch
from
4818474 to
cb89845
Compare
ahmadnaufal
force-pushed
the
feat/grant-drift-check-notify-pd
branch
from
584e7c5 to
08003bb
Compare
anjali9791
reviewed
Jun 2, 2026
| return accountTypeRAMUser | ||
| } | ||
|
|
||
| func (p *provider) listResourceAccess(ctx context.Context, overrideRAMRole string, pc *domain.ProviderConfig, resource *domain.Resource) ([]domain.AccessEntry, error) { |
Collaborator
There was a problem hiding this comment.
We are fetching this for all users not just bots ?
Is it tested? How much time does it take to complete?
Author
There was a problem hiding this comment.
Yes, but we'll only provide the distinct resources for all the bots' active grants.
Already tested on a very small set of resources (2 projects, 1 schema, and 3 tables) and each request took less than 5 secs with the current concurrency settings
anjali9791
reviewed
Jun 2, 2026
| }, | ||
| } | ||
| if _, err := pagerduty.ManageEventWithContext(ctx, v2event); err != nil { | ||
| return fmt.Errorf("sending pagerduty event: %w", err) |
Collaborator
There was a problem hiding this comment.
should we say error sending pagerduty event, it would be easy to look for error keyword when someone does not know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.