feat(provider): encrypt credentials on higher field level#40
Open
rahmatrhd wants to merge 3 commits into
Open
Conversation
rahmatrhd
force-pushed
the
provider-plugin-refactor
branch
from
98e6f64 to
dacc525
Compare
mabdh
reviewed
Jun 5, 2023
Comment on lines
+218
to
+221
| if p.Config.Credentials != nil { | ||
| // decode any base64 encoded string within credentials | ||
| decodeBase64Values(p.Config.Credentials) | ||
| } |
Member
There was a problem hiding this comment.
Sorry I kinda forgot with this but is there any reason to do base64 decoding inside this business logic instead of doing it right after reading it from Config file?
lifosmin
pushed a commit
to lifosmin/guardian
that referenced
this pull request
Aug 31, 2023
* feat: add created_by & updated_by to resource * fix: place the new fields at last
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: