feat: new field for list approvals#233
Open
lifosmin wants to merge 2 commits into
Open
Conversation
added 2 commits
May 20, 2026 16:44
anjali9791
reviewed
Jun 2, 2026
| bool summary_labels = 61; | ||
| // If true, includes label summaries using faceted search: for each label key, available values are computed by applying all other active label filters except that key. Mutually exclusive with summary_labels. | ||
| bool summary_labels_v2 = 62; | ||
| // If true, populates previous_grant_expiration_date on each returned approval by looking up the latest grant matching the appeal's account_id, resource_id, and role. |
Collaborator
There was a problem hiding this comment.
and group_id and group_type. You can update the comment.
anjali9791
reviewed
Jun 2, 2026
| // If true, populates previous_grant_expiration_date on each returned approval by looking up the latest grant matching the appeal's account_id, resource_id, and role. | ||
| bool with_previous_grant = 63; | ||
| // When set together with end_expiration_date, only returns approvals whose previous_grant_expiration_date falls within [start_expiration_date, end_expiration_date]. Requires with_previous_grant=true. | ||
| optional google.protobuf.Timestamp start_expiration_date = 64; |
Collaborator
There was a problem hiding this comment.
This will work if end_expiration_date is not given as well, right?
anjali9791
approved these changes
Jun 2, 2026
anjali9791
reviewed
Jun 2, 2026
| // - expired: the latest grant matching the appeal's (account_id, resource_id, role) has expiration_date < now. | ||
| // - expiring: the latest matching grant expires within expiring_within_days days from now (defaults to 7 when omitted). | ||
| // - none: no previous grant exists for the triple, or the latest grant is permanent (expiration_date IS NULL). | ||
| string previous_grant_state = 66; |
Collaborator
There was a problem hiding this comment.
It should be an array, in same request I would need for expired and expiring. Lets say currently there are 2 appeals
Appeal A1: Grant expired on 1st June
Appeal A2:Grant expiring on 5th June.
I need to show expiration_date for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.