This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Fix docs for control inputs with initial checked state #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azerella
suggested changes
Nov 13, 2018
|
no need to change it for the actual component itself. It's just a fix in the example. then will update the example in designsystem.gov.au. I updated my comment in the PR to make it more clear. |
|
@sukhrajghuman Now I'm more confused lol, the codepen example sets |
|
It sets |
|
@sukhrajghuman Ahh, gotcha - LGTM |
azerella
approved these changes
Nov 14, 2018
|
We need to clean these PR's up they have a lot of unrelated file changes 👍 |
Since this is an uncontrolled component, passing the `checked` prop is overriding the `checked` attribute in the DOM. If we use `defaultChecked` it will allow for subsequent updates to be uncontrolled.
azerella
force-pushed
the
feature/changed-control-input-to-defaultchecked
branch
from
e616a43 to
4420b7c
Compare
|
@alex-page Fixed with a rebase |
sukhrajghuman
deleted the
feature/changed-control-input-to-defaultchecked
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is an uncontrolled component, passing the
checkedattribute in<AUradio>and<AUcheckbox>is overriding thecheckedattribute in the DOM. This means the checkbox/radio box will remain checked. If we usedefaultChecked, it will be checked initially and allow for subsequent updates to be uncontrolled.fixes #544
I'm also going to put #548 on hold for now. I believe it's fairly low priority.