Order users list in the database rather than in memory

[DavidBiddle]

What problem does this pull request solve?

Trello card: https://trello.com/c/UXjZG0ZG/2946-improve-load-speed-on-users-page

This is an attempt to fix the performance issue we see on the Users page doing the ordering in the database query, rather than ordering the items in memory in the app after they've been fetched from the database.

Things to consider when reviewing

• Ensure that you consider the wider context.
• Does it work when run on your machine?
• Is it clear what the code is doing?
• Do the commit messages explain why the changes were made?
• Are there all the unit tests needed?
• Do the end to end tests need updating before these changes will pass?
• Has all relevant documentation been updated?

[DavidBiddle]

I haven't figured out how to test this yet, since the issue is only noticeable in prod

[theseanything]

Think this is a good idea regardless, our current implementation is causes a database query per user (i.e. 2000+ query's to load the users page) due to the user.organisation&.name, which means it needs to fetch each organisation individually.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2050.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

[stephencdaly]

This was included in #2229