Skip to content

Enable new typography scale#2070

Merged
DavidBiddle merged 1 commit into
mainfrom
enable-new-type-scale
Jul 16, 2025
Merged

Enable new typography scale#2070
DavidBiddle merged 1 commit into
mainfrom
enable-new-type-scale

Conversation

@DavidBiddle

@DavidBiddle DavidBiddle commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/O48UNuIf/2364-switch-to-new-type-scale-for-admin

Switches on the new govuk-frontend type scale.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle force-pushed the enable-new-type-scale branch from 363089b to 9bf07a2 Compare July 16, 2025 07:56
@DavidBiddle DavidBiddle force-pushed the enable-new-type-scale branch from 9bf07a2 to aab8ba2 Compare July 16, 2025 09:27
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2070.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@DavidBiddle DavidBiddle marked this pull request as ready for review July 16, 2025 10:02

@thomasiles thomasiles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the review app ⚖️

@DavidBiddle DavidBiddle merged commit c2d641e into main Jul 16, 2025
7 checks passed
@DavidBiddle DavidBiddle deleted the enable-new-type-scale branch July 16, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants