Skip to content

Add FormCopyService#2271

Closed
chao-xian wants to merge 3 commits into
mainfrom
spike-copy-form
Closed

Add FormCopyService#2271
chao-xian wants to merge 3 commits into
mainfrom
spike-copy-form

Conversation

@chao-xian
Copy link
Copy Markdown
Contributor

@chao-xian chao-xian commented Oct 8, 2025

What problem does this pull request solve?

https://trello.com/c/Ty4nxyXi/2613-timebox-2-days-tech-spike-into-make-a-copy-of-a-form

This is missing copying the other Conditions (it only deals with RoutingConditions) but the principles are the same.

Another thing missing is setting the Group (via a new GroupForm) but it's trivial.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian force-pushed the spike-copy-form branch 2 times, most recently from 159f71b to 6876255 Compare October 8, 2025 13:07
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2271.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian mentioned this pull request Nov 19, 2025
@chao-xian
Copy link
Copy Markdown
Contributor Author

Replaced by #2338

@chao-xian chao-xian closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant