Add link to add Welsh translations for a form#2283
Merged
Conversation
chao-xian
force-pushed
the
add-welsh-task
branch
from
d0dc2da to
53e5b99
Compare
chao-xian
force-pushed
the
add-welsh-task
branch
2 times, most recently
from
5608b1f to
f881314
Compare
thomasiles
reviewed
Oct 22, 2025
thomasiles
reviewed
Oct 22, 2025
thomasiles
reviewed
Oct 22, 2025
thomasiles
reviewed
Oct 22, 2025
chao-xian
force-pushed
the
add-welsh-task
branch
3 times, most recently
from
a728126 to
69fbdd2
Compare
thomasiles
reviewed
Oct 24, 2025
chao-xian
force-pushed
the
add-welsh-task
branch
3 times, most recently
from
673ad18 to
0867fc5
Compare
This goes nowhere atm as it's only the link we're adding.
Most cases should be that there's an associated group. Now that we check whether a Group has the Welsh feature enabled, actions on a form on whether to do anything Welsh related are more dependent on there being a Group. # Conflicts: # spec/factories/models/form_record.rb
Based on whether the feature is enabled.
We can uncouple Form and EmailTaskStatusService/TaskStatusService.
chao-xian
force-pushed
the
add-welsh-task
branch
from
f378f9d to
b46a465
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2283.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/s3slDSAo/2637-add-new-task-link-to-task-list-for-adding-a-welsh-version
This goes nowhere atm as it's only the link we're adding.
Had to refactor the section numbers code to allow some way of making it dynamically change based on whether the feature is switched on. A loop over the sections wouldn't work as there wasn't a way to skip the subsections and have the correct number for the next loop.
Can't exercise the status code much atm as we don't have any translations.
Things to consider when reviewing