Skip to content

Copy a form#2420

Merged
chao-xian merged 8 commits into
mainfrom
copy-a-form
Dec 17, 2025
Merged

Copy a form#2420
chao-xian merged 8 commits into
mainfrom
copy-a-form

Conversation

@chao-xian
Copy link
Copy Markdown
Contributor

@chao-xian chao-xian commented Dec 8, 2025 •
edited
Loading

What problem does this pull request solve?

Adds copying of forms functionality. Builds upon work in #2338

Trello card: https://trello.com/c/F5ceg6WU

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian force-pushed the copy-a-form branch 4 times, most recently from 5fba617 to 85dddd6 Compare December 15, 2025 12:43
@chao-xian chao-xian marked this pull request as ready for review December 15, 2025 12:49
@chao-xian chao-xian mentioned this pull request Dec 15, 2025
Closed
@chao-xian chao-xian requested a review from thomasiles December 15, 2025 12:52
thomasiles
thomasiles reviewed Dec 15, 2025
View reviewed changes
Comment thread app/views/forms/show.html.erb Outdated
Comment thread config/locales/en.yml
Comment thread spec/views/forms/show.html.erb_spec.rb Outdated
Comment thread app/views/forms/copy/confirm.html.erb Outdated
Comment thread spec/requests/forms/copy_controller_spec.rb
@chao-xian chao-xian force-pushed the copy-a-form branch 3 times, most recently from de8171a to 5cb03a4 Compare December 16, 2025 11:57
@chao-xian
Copy link
Copy Markdown
Contributor Author

chao-xian commented Dec 16, 2025

it's occurred to me that I should change ?tag=live to just copy/live and map that in routes.rb...

DavidBiddle
DavidBiddle reviewed Dec 16, 2025
View reviewed changes
Comment thread app/views/forms/copy/confirm.html.erb Outdated
thomasiles
thomasiles approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Back links for copying live forms don't go back to the right screen but that can be fixed later

@chao-xian
Add CopyInput object
cefc0fa 
This is for the confirmation screen where the user can update the name of the copied form.
@chao-xian
Refactor methods into web_controller
24a3e9d 
These are needed in places other than their current controllers.
@chao-xian
Update Form policy to allow copying
6029de7
@chao-xian
Add controller, route and view for Copying a Form
2b51b30
@chao-xian
Update views to have the Copy button
67349d7
@chao-xian
Add feature spec for Copying Forms
1d7e876 
^ Conflicts:
^	spec/features/form/copy_a_form_spec.rb
@chao-xian
Update routes to accept Tag param as part of path
a68eda5 
More Rails like and cleans up the tests a little bit.
@chao-xian
Update helper translations to be conventional structure
238ad09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 17, 2025

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2420.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@chao-xian chao-xian merged commit 9abbf78 into main Dec 17, 2025
6 checks passed
@chao-xian chao-xian deleted the copy-a-form branch December 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBiddle DavidBiddle DavidBiddle left review comments

@thomasiles thomasiles thomasiles approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chao-xian @DavidBiddle @thomasiles