Skip to content

Update copy code to also copy Welsh#2476

Merged
chao-xian merged 1 commit into
mainfrom
copy-welsh
Jan 12, 2026
Merged

Update copy code to also copy Welsh#2476
chao-xian merged 1 commit into
mainfrom
copy-welsh

Conversation

@chao-xian
Copy link
Copy Markdown
Contributor

@chao-xian chao-xian commented Jan 9, 2026

What problem does this pull request solve?

FormCopyService was only copying the English version of a form and ignoring if the form has a Welsh translation. This PR now copies both (if a Welsh version exists).

Trello card: https://trello.com/c/t30RB6CI/2759-needed-before-launch-update-copy-form-to-work-with-welsh-forms

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@chao-xian chao-xian force-pushed the copy-welsh branch 3 times, most recently from a236485 to 99d36e9 Compare January 12, 2026 13:49
@chao-xian chao-xian marked this pull request as ready for review January 12, 2026 13:51
@chao-xian chao-xian enabled auto-merge January 12, 2026 13:51
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2476.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in review and the code looks good 🎉

@chao-xian chao-xian added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 5611541 Jan 12, 2026
6 checks passed
@chao-xian chao-xian deleted the copy-welsh branch January 12, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants