Fix description for skip to end secondary skip route#2477
Merged
Conversation
For the case where a secondary skip skips to the end of the form, there is no `answer_value` associated with the condition. This meant we were displaying: ``` If the answer is “” then skip to “Check your answers before submitting” ``` Display a more appropriate description in this case.
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2477.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
lfdebrux
approved these changes
Jan 13, 2026
hannahkc
approved these changes
Jan 13, 2026
Contributor
hannahkc
left a comment
There was a problem hiding this comment.
content looks good. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this pull request solve?
Trello card: https://trello.com/c/XAGyVK60/3020-secondary-skip-to-end-of-the-form-displays-incorrectly-in-the-live-form-page-summary
For the case where a secondary skip skips to the end of the form, there is no
answer_valueassociated with the condition. This meant we were displaying:Display a more appropriate description in this case.
Things to consider when reviewing