Skip to content

Fix description for skip to end secondary skip route#2477

Merged
stephencdaly merged 1 commit into
mainfrom
fix-secondary-skip-route-description
Jan 13, 2026
Merged

Fix description for skip to end secondary skip route#2477
stephencdaly merged 1 commit into
mainfrom
fix-secondary-skip-route-description

Conversation

@stephencdaly
Copy link
Copy Markdown
Contributor

@stephencdaly stephencdaly commented Jan 12, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/XAGyVK60/3020-secondary-skip-to-end-of-the-form-displays-incorrectly-in-the-live-form-page-summary

For the case where a secondary skip skips to the end of the form, there is no answer_value associated with the condition. This meant we were displaying:

If the answer is “”
then skip to “Check your answers before submitting”

Display a more appropriate description in this case.

Screenshot 2026-01-12 at 17 46 34

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

For the case where a secondary skip skips to the end of the form,
there is no `answer_value` associated with the condition. This meant
we were displaying:

```
If the answer is “”
then skip to “Check your answers before submitting”
```

Display a more appropriate description in this case.
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2477.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly stephencdaly requested a review from hannahkc January 13, 2026 09:54
Copy link
Copy Markdown
Contributor

@hannahkc hannahkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good. thanks!

@stephencdaly stephencdaly added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@stephencdaly stephencdaly added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit af33a5e Jan 13, 2026
8 checks passed
@stephencdaly stephencdaly deleted the fix-secondary-skip-route-description branch January 13, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants