Remove weekly_submission_batch feature flag

[SamJamCul]

What problem does this pull request solve?

https://trello.com/c/StdVI6BN/2920-remove-feature-flag-for-weekly-batches

Things to consider when reviewing

• Ensure that you consider the wider context.
• Does it work when run on your machine?
• Is it clear what the code is doing?
• Do the commit messages explain why the changes were made?
• Are there all the unit tests needed?
• Do the end to end tests need updating before these changes will pass?
• Has all relevant documentation been updated?

[thomasiles]

Looks good to me, can we remove

forms-admin/config/settings.yml

Line 5 in fb35af2

weekly_submission_emails_enabled: false

as well?

[SamJamCul]

Looks good to me, can we remove

forms-admin/config/settings.yml

Line 5 in fb35af2

weekly_submission_emails_enabled: false

as well?

Very good idea! It's gone now

[github-actions]

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2709.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

[thomasiles]

nice!