Skip to content

Add message to routes#show when not enough pages#2785

Merged
thomasiles merged 1 commit into
mainfrom
add-warning-no-routable-pages
May 19, 2026
Merged

Add message to routes#show when not enough pages#2785
thomasiles merged 1 commit into
mainfrom
add-warning-no-routable-pages

Conversation

@thomasiles

Copy link
Copy Markdown
Contributor

Stop showing an empty form on the routes page

Trello card: https://trello.com/c/bOtP0QNS/3086-remove-the-save-and-continue-button-from-the-routes-page-when-there-are-less-than-2-pages-in-the-form

Instead of showing the routes form when there are not enough pages, show a warning and a link to the question pages.

We show the message when there is 0 or 1 page.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@thomasiles thomasiles force-pushed the add-warning-no-routable-pages branch from 95dafee to 3c5052f Compare May 15, 2026 13:21
@thomasiles thomasiles marked this pull request as ready for review May 15, 2026 13:24
lfdebrux
lfdebrux previously approved these changes May 18, 2026
@hannahkc

Copy link
Copy Markdown
Contributor

Content looks grand!

Instead of showing the routes form when there are not enough pages, show
a warning and a link to the question pages.

We show the message when there is 0 or 1 page.
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2785.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles thomasiles added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 8dbda43 May 19, 2026
3 checks passed
@thomasiles thomasiles deleted the add-warning-no-routable-pages branch May 19, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants