Fix content for none of the above option when adding and editing routes#2797
Open
lfdebrux wants to merge 3 commits into
Open
Fix content for none of the above option when adding and editing routes#2797lfdebrux wants to merge 3 commits into
lfdebrux wants to merge 3 commits into
Conversation
This translation was just repeating back its input, so wasn't needed.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2797.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
Contributor
|
Content looks grand - thank so much for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
While working on multiple branches, we noticed that the existing routing implementation is missing content for the situation when the answer value for a condition is the none of the above option for an optional selection question; the pages rendered the answer value as
none_of_the_above.This PR adds the missing content.
Screenshots
Showing a route
Deleting a route
Adding a secondary skip to a route
Things to consider when reviewing