Add tasks for making individual languages live#2810
Conversation
37f69d5 to
2b96e45
Compare
16286e4 to
b219ae9
Compare
7e32fdf to
ad57f20
Compare
Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
ce34bef to
b947da1
Compare
We need to prevent Welsh forms being made live if there are changes to the English draft since the form was made live. If we don't, it's possible for a user to: - make an English version of the form live - make a change to that English version (e.g. adding or deleting a question) - complete the Welsh translations for the form - make the Welsh version live without making the English changes live In this case the different language versions would be out of sync, as the English and Welsh form documents would be from before and after the change respectively. This would lead to unexpected behaviour for form fillers when switching languages.
89d4e46 to
e86a48e
Compare
When we make the English version of a form live, we want the form state to be 'live_with_draft' rather than 'live' - this reflects the fact that the form still has changes to be made live.
e86a48e to
6561dbe
Compare
stephencdaly
left a comment
There was a problem hiding this comment.
It's comprehensively tested, and works for me locally
|
@StephenGill please could you review the content for this journey? You should be able to see it working on this form on the review apps: https://pr-2810.admin.review.forms.service.gov.uk/forms/5 |
This is my first time looking at this feature , so I struggled to find the relevant part of the Mural to compare it with. And I couldn't access the relevant screens on the review app - I must have selected the wrong user profile, and it won't let me log in using a different profile (despite clearing my cookies). But based on the screenshots in the PR - the link text used in screenshot 1 is 'Make your English form live' - rather than 'Make the changes to your English form live', which would be more consistent with the other screenshots. This might well have been a conscious choice, in which case it's fine - just mentioning it in case it's a mistake. |
|
@StephenGill not a conscious choice on my part - I've been going off this bit of the Mural board: https://app.mural.co/t/gaap0347/m/gaap0347/1757516003408/d58a0d5502b18b5eea0c9cc782b2d014a7bccfcb?wid=0-1764321012841 The Mural board doesn't really account (as far as I can tell) for making changes, just the initial make live journey - I think elsewhere we use 'Make your form live' the first time a form goes live and 'Make your changes live' on subsequent changes. Do you reckon we should add extra content here to make that consistent before merging this? |
|
@DavidBiddle I can see how people might read 'Make your form live' as suggesting that the form isn't already live - so might cause confusion. So personally I think it's worth doing, provided it doesn't hold up shipping significantly. So if there's no Welsh version, would be 'Make your form live' / 'Make changes to your form live'. Otherwise would be 'Make changes to your English form live' or 'Make changes to your Welsh form live'. |
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2810.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
What problem does this pull request solve?
Trello card: https://trello.com/c/nE8FUqW4/2892-separate-make-your-english-welsh-form-live-task-on-task-page
Adds new tasks to the task list, which will appear when the form:
These replace the existing make live task for Welsh forms.
Screenshots
A form with Welsh content and unpublished English changes:

A form with Welsh content and a live English version:

A draft form with no Welsh content:

A live form with a live Welsh version:

Things to consider when reviewing