This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Remove next_page column from pages table#792
Merged
Merged
Conversation
This column hasn't been used since before we migrated from grape (see PR #116), when we migrated to grape we switched to using the acts_as_list gem and the position column instead (see commit e8cc03). Let's remove this column now. Note that we do still need the `next_page` attribute in our JSON responses, as it used by consumers, but it is calculated by a method based on the acts_as_list code, we don't need it in our database.
lfdebrux
force-pushed
the
ldeb-remove-next-page-from-pages
branch
from
16e06e1 to
c9d2023
Compare
|
theseanything
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
This column hasn't been used since before we migrated from grape (see PR #116), when we migrated to grape we switched to using the acts_as_list gem and the position column instead (see commit e8cc03).
Let's remove this column now. Note that we do still need the
next_pageattribute in our JSON responses, as it used by consumers, but it is calculated by a method based on the acts_as_list code, we don't need it in our database.The column was ignored in #791, so is now safe to actually remove the column.
Things to consider when reviewing