This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Change response of /api/v1/forms/:id/make-live#793
Merged
Conversation
forms-admin had been assuming that the response from POST-ing to the make_live endpoint is a form object, but it's actually the made live form document. This is less useful because it doesn't contain the state (the attribute that is actually changed), and differs from the response that we get from the archive endpoint, even though they're the conceptually similar actions. This commit changes the response to be the updated form object as expected.
|
SamJamCul
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
forms-admin had been assuming that the response from POST-ing to the make_live endpoint is a form object (see for instance https://github.com/alphagov/forms-admin/blob/4ce3b3473dcc48627cf387de156f37d06126a91e/app/services/form_repository.rb#L34-L43), but it's actually the made live form document. This is less useful because it doesn't contain the state (the attribute that is actually changed), and differs from the response that we get from the archive endpoint, even though they're the conceptually similar actions.
This commit changes the response to be the updated form object as expected.
Things to consider when reviewing