This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Remove Reports Controller and services#794
Merged
SamJamCul merged 1 commit intoJul 11, 2025
Merged
Conversation
SamJamCul
force-pushed
the
2373-move-feature-report-code-from-forms-api-to-forms-admin
branch
from
fb7e68f to
c40de56
Compare
lfdebrux
reviewed
Jul 11, 2025
Contributor
lfdebrux
left a comment
lfdebrux
left a comment
There was a problem hiding this comment.
Oh, we can also remove the routes from config/routes.rb
We're moving the reports directly into Forms Admin, so we no longer need to serve them from the API.
SamJamCul
force-pushed
the
2373-move-feature-report-code-from-forms-api-to-forms-admin
branch
from
c40de56 to
868ffd0
Compare
|
SamJamCul
deleted the
2373-move-feature-report-code-from-forms-api-to-forms-admin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/5WfLpFRG/2373-move-feature-report-code-from-forms-api-to-forms-admin
Once govuk-forms/forms-admin#2072 is in, we can remove all the migrated reports from Forms API. This PR gets rid of the report services and the endpoints that served them.
Things to consider when reviewing