Appease TFLint#1506
Merged
Merged
Conversation
cadmiumcat
approved these changes
Apr 11, 2025
Contributor
cadmiumcat
left a comment
cadmiumcat
left a comment
There was a problem hiding this comment.
Niiice, it all looks good to me 🙌
I love the idea of setting a deadline for fixing these
Disabled because we use a shared "inputs.tf" file and a set of ".tfvars" filesin a lot of places and tflint is unable to tell the difference between a variable being unused in a particular root and a variable being completely unused.
Later commits will address the failures that cannot be automatically fixed.
Previously we pointed TFLint at the "infra/deployments/forms" directory (for example) and used the "--recursive" flag to have it check each directory. This was causing it to evaluate the submodules of those roots as their own roots. Instead of doing that, we now use the existing lists of roots within the Makefile to run TFLint against each root individually, and do away with "--recursive".
We previously were taking TFLint's errors as warnings, and giving ourselves until a deadline to fix them. We have now fixed them and can remove the deadline code.
cadmiumcat
force-pushed
the
appease_tflint
branch
from
524742f to
fd30469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/G1BmcjHp/646-relax-by-appeasing-tflint
We introduced TFLint a while back, took the failures as warnings, and set ourselves a deadline to fix them. We are now fixing them!
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully