Set Europe/London timezone in pipeline-visualiser container#1507
Merged
Conversation
The timezone needs to be set explicitly to Europe/London in order to show the correct time in tool.
Contributor
|
Is there a way we could get it to show the timezone based on the browser locale? |
Contributor
Author
|
I dunno, I'll have a look into it! |
Running the visualiser in Docker is useful for replicating how it behaves in production
Contributor
Author
|
I've addressed it with a little bit of JS to reformat the dates into local time. I couldn't see that HTTP requests send client timezone information with them, so it wasn't possible to do server side. |
lfdebrux
reviewed
Apr 9, 2025
lfdebrux
reviewed
Apr 9, 2025
lfdebrux
reviewed
Apr 9, 2025
…is available A progressive enhancement. Otherwise the user will see the times as server times (Europe/London).
0691b20 to
08f1d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/gg3J5mMT/434-visualiser-fix-timezone
The timezone needs to be set explicitly to Europe/London in order to show the correct time in tool. Ruby respects the timezone information when it's present, and automatically converts timestamps with a timezone attached into the local time.
How to review
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully