Skip to content

Add feature flag for using AWS SES for all submission emails#1514

Merged
jamie-o-wilkinson merged 1 commit into
mainfrom
add-ses-submissions-feature-flag
Apr 10, 2025
Merged

Add feature flag for using AWS SES for all submission emails#1514
jamie-o-wilkinson merged 1 commit into
mainfrom
add-ses-submissions-feature-flag

Conversation

@jamie-o-wilkinson
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/C8KYvyW8

Add a feature flag to enable sending all submissions via AWS SES.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@jamie-o-wilkinson jamie-o-wilkinson self-assigned this Apr 10, 2025
@jamie-o-wilkinson jamie-o-wilkinson changed the title Add ses_submissions feature flag Add feature flag for using AWS SES for all submission emails Apr 10, 2025
@jamie-o-wilkinson jamie-o-wilkinson marked this pull request as ready for review April 10, 2025 10:37
@jamie-o-wilkinson jamie-o-wilkinson merged commit 02c9187 into main Apr 10, 2025
5 checks passed
@jamie-o-wilkinson jamie-o-wilkinson deleted the add-ses-submissions-feature-flag branch April 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants