Remove unused policies and variables for state locking with dynamodb#1515
Merged
Conversation
cadmiumcat
force-pushed
the
native-s3-object-locking
branch
from
0b6460f to
9c08bf5
Compare
cadmiumcat
force-pushed
the
remove-dynamodb-tables
branch
from
b37ffb6 to
1068fb7
Compare
cadmiumcat
force-pushed
the
native-s3-object-locking
branch
from
8059c3b to
10e8f86
Compare
cadmiumcat
force-pushed
the
remove-dynamodb-tables
branch
from
1068fb7 to
a7659a3
Compare
cadmiumcat
changed the title
sarahseewhy
approved these changes
Apr 17, 2025
Contributor
sarahseewhy
left a comment
sarahseewhy
left a comment
There was a problem hiding this comment.
Thanks for the thorough cleanup! 🚀
Since we are using terraform's native s3 state locking (#1476) we no longer need have dynamodb tables or the permissions associated with it
cadmiumcat
force-pushed
the
remove-dynamodb-tables
branch
from
13a2020 to
477c7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Since we are using terraform's native s3 state locking (#1476) we no longer need have dynamodb tables or the permissions associated with it
Trello card
Things to consider when reviewing
We should only merge and apply this PR after #1476
I've applied this to dev with not backlash!
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully