Skip to content

Allow readonly roles to lock Terraform state files#1538

Merged
AP-Hunt merged 1 commit into
mainfrom
readonly_roles_allow_locking
Apr 29, 2025
Merged

Allow readonly roles to lock Terraform state files#1538
AP-Hunt merged 1 commit into
mainfrom
readonly_roles_allow_locking

Conversation

@AP-Hunt
Copy link
Copy Markdown
Contributor

@AP-Hunt AP-Hunt commented Apr 29, 2025

What problem does this pull request solve?

Previously the permission was granted through a policy giving DynamoDB permissions. We must now grant very limited permissions in S3 instead.

Note

This will need applying by hand in each environment

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

Previously the permission was granted through a policy giving DynamoDB
permissions. We must now grant very limited permissions in S3 instead.
Copy link
Copy Markdown
Contributor

@sarahseewhy sarahseewhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@AP-Hunt AP-Hunt merged commit 1de390e into main Apr 29, 2025
4 checks passed
@AP-Hunt AP-Hunt deleted the readonly_roles_allow_locking branch April 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants