Skip to content

Turn on SES submission for all forms#1540

Merged
DavidBiddle merged 2 commits into
mainfrom
turn-on-ses-submission
Apr 30, 2025
Merged

Turn on SES submission for all forms#1540
DavidBiddle merged 2 commits into
mainfrom
turn-on-ses-submission

Conversation

@DavidBiddle
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle commented Apr 30, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/v96Mi8mG/2227-enable-submission-emails-via-aws-ses

Turns the SES submission feature flag on in Production, Staging and User Research environments. We enabled it in dev previously (#1536) so once this is merged the feature should be on in all environments.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@DavidBiddle DavidBiddle marked this pull request as ready for review April 30, 2025 09:34
@DavidBiddle DavidBiddle merged commit 591ffcb into main Apr 30, 2025
5 checks passed
@DavidBiddle DavidBiddle deleted the turn-on-ses-submission branch April 30, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants