Skip to content

BAU: Remove branch specifier from terraform-ci#1846

Merged
whi-tw merged 1 commit into
mainfrom
whi-tw/remove-terraform-ci-branch-spec
Nov 25, 2025
Merged

BAU: Remove branch specifier from terraform-ci#1846
whi-tw merged 1 commit into
mainfrom
whi-tw/remove-terraform-ci-branch-spec

Conversation

@whi-tw
Copy link
Copy Markdown
Contributor

@whi-tw whi-tw commented Nov 13, 2025

What problem does this pull request solve?

We sometimes create PRs against feature branches when working on
multi-PR changes. The branch specifier meant that the terraform-ci
workflow would not run for these PRs which was unhelpful.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

Copilot AI review requested due to automatic review settings November 13, 2025 12:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the branch specifier from the terraform-ci workflow to enable it to run on pull requests targeting any branch, not just main. This allows the workflow to execute when creating PRs against feature branches during multi-PR development work.

  • Removed branches: [main] constraint from the pull_request trigger in terraform-ci workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@whi-tw whi-tw force-pushed the whi-tw/remove-terraform-ci-branch-spec branch from a5dbee2 to e80296e Compare November 13, 2025 14:43
Copy link
Copy Markdown
Contributor

@sarahseewhy sarahseewhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why this change is required 🚀

I'd be curious to know why we originally limited the PR to just main. Git history isn't helpful unfortunately.

@whi-tw whi-tw enabled auto-merge November 25, 2025 10:01
We sometimes create PRs against feature branches when working on
multi-PR changes. The branch specifier meant that the terraform-ci
workflow would not run for these PRs which was unhelpful.
Copilot AI review requested due to automatic review settings November 25, 2025 10:02
@whi-tw whi-tw force-pushed the whi-tw/remove-terraform-ci-branch-spec branch from e80296e to 2bc9ee6 Compare November 25, 2025 10:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@whi-tw whi-tw merged commit 16b7340 into main Nov 25, 2025
15 of 18 checks passed
@whi-tw whi-tw deleted the whi-tw/remove-terraform-ci-branch-spec branch November 25, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants